Replace use of block with lambda to fix wrong number of arguments err… #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or on jruby-9.3.4.0 on docker
This is a strange one. Running tests on docker, prior to this test, the call to when_complete using a block
for the BiConsumer parameter would fail with the following error:
```
[2022-06-08T15:31:49,587][ERROR][logstash.inputs.azureeventhubs] Event Hub failed during initialization. {:event_hub_name=>"event_hub_name0", :exception=>#<ArgumentError: wrong number of arguments (given 0, expected 1)>, :backtrace=>["/usr/share/plugins/plugin/lib/logstash/inputs/azure_event_hubs.rb:435:in `block in run'"]}
```
Running the tests locally, this does not fail on my development machine (MacOsX x86_64), but does
fail in the dockerized test environment. Attempting to create a simple reproducer against a BiConsumer also
does not fail.
9 tasks
|
https://app.travis-ci.com/github/logstash-plugins/logstash-input-azure_event_hubs/jobs/572881450 is an example of a failure |
kares
approved these changes
Jun 13, 2022
|
This is likely due to jruby/jruby#7246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or on jruby-9.3.4.0 on docker
This is a strange one. Running tests on docker, prior to this test, the call to when_complete using a block
for the BiConsumer parameter would fail with the following error:
Running the tests locally, this does not fail on my development machine (MacOsX x86_64), but does
fail in the dockerized test environment. Attempting to create a simple reproducer against a BiConsumer also
does not fail.