Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson dependencies in CI tests #43

Merged
merged 3 commits into from
Jul 17, 2019

Conversation

robbavey
Copy link
Contributor

No description provided.

@elasticsearch-bot elasticsearch-bot self-assigned this Jul 16, 2019
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to work as-advertised. I've left a note about potentially safeguarding a little harder against consuming breaking changes from jackson 3.x. Feel free to resolve as you see fit, LGTM either way.

@@ -89,17 +89,17 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.9.8</version>
<version>[2.9.9,)</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe specifying [2.9.9,3.0) would be safer, ensuring that we don't accidentally pick up breaking changes from 3.x when it rolls out.

@yaauie yaauie assigned yaauie and unassigned elasticsearch-bot Jul 17, 2019
@robbavey robbavey merged commit e75f658 into logstash-plugins:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants