Actually set maxBatchSize on EventProcessor #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `max_batch_size` option was being ignored when creating the event processor, leading to a default batch size of 10, instead of the intended 125, and not allowing users to change their batch size. This caused the potential for much more frequent checkpointing of completed event batches, potentially causing performance issues.
jsvd
reviewed
Feb 28, 2020
Co-Authored-By: João Duarte <jsvd@users.noreply.github.com>
jsvd
approved these changes
Feb 28, 2020
|
Great catch @robbavey :) |
|
Post-merge LGTM 👍 Good work on adding clarity to the logs, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_batch_sizeoption was being ignored when creating theevent processor, leading to a default batch size of 10, instead of
the intended 125, and not allowing users to change their batch size.