-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build script to run with Gradle 7 #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3f0829
to
63e6d1b
Compare
25 tasks
jsvd
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jsvd
reviewed
Oct 27, 2021
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
jsvd
reviewed
Oct 27, 2021
jsvd
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andsel
added a commit
to andsel/logstash-input-azure_event_hubs
that referenced
this pull request
Oct 28, 2021
…iguration In PR logstash-plugins#69 the build.gradle was updated to run on Gradle 7, part of the change consisted in forcing the resolution of 'implementation' configuration to use it in the listing of dependencies. This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick. Relates logstash-plugins#69
6 tasks
andsel
added a commit
that referenced
this pull request
Oct 28, 2021
…iguration (#70) In PR #69 the build.gradle was updated to run on Gradle 7, part of the change consisted in forcing the resolution of 'implementation' configuration to use it in the listing of dependencies. This could be assolved by the 'runtimeClasspath' without forcing the resolution which smells like a trick. Relates #69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Update build infrastructure to Gradle 7.2
What does this PR do?
Update the Gradle wrapper used to version 7.2 and fixed
build.gradle
script.Why is it important/What is the impact to the user?
Developers can use JDK >= 17 to build the plugin
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Run
./gradlew clean vendor
Related issues