Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually set prefetch count and receive timeout values #61

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

robbavey
Copy link
Contributor

@robbavey robbavey commented Nov 6, 2020

Prefetch count and receive timeout configurations are mentioned in
part of the source code, and treated as advanced configuration options,
but not actually set in the EventProcessorOptions.

This commit allows these values to be set, but maintains the existing
policy of not documenting these values.

Fixes #60

Prefetch count and receive timeout configurations are mentioned in
part of the source code, and treated as advanced configuration options,
but not actually set in the EventProcessorOptions.
Exposing these options allows advanced EventHub users to tweak configuration
settings to potentially improve performance.

This commit allows these values to be set, but maintains the existing
policy of not documenting these values.
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM (hence approving) but the CI is failing. Please investigate that before landing.

@yaauie
Copy link
Contributor

yaauie commented Nov 7, 2020

CI should be fixed when logstash-plugins/.ci#19 is merged

@robbavey robbavey merged commit 322e47a into logstash-plugins:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefetch_count value is ignored
4 participants