Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: make log4j-api a provided dependency #73

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Build: make log4j-api a provided dependency #73

merged 3 commits into from
Jan 4, 2022

Conversation

kares
Copy link
Contributor

@kares kares commented Jan 3, 2022 •
edited
Loading

  • the log4j-api becomes a compileOnly 'org.apache.logging.log4j:log4j-api:2.17.0'
    there's no compilation happening but it's still a (Logstash) provided dependency ...
  • log4j-slf4j-impl does not make sense to even be a compile-only dep, it's an (slf4j) api impl
    NOTE: that LS has provided log4j-slf4j-impl at least since 6.0

@kares kares marked this pull request as ready for review January 3, 2022 11:25
@andsel andsel self-requested a review January 4, 2022 08:04
andsel
andsel approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally with LS 7.14.1 and it print Azure library logs correctly

@kares kares merged commit 6e5c9b2 into logstash-plugins:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kares @andsel @roaksoax