Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Format examples for easier parsing #90

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Jun 5, 2024

Fixes: #89

PREVIEW:
Screen Shot 2024-06-06 at 6 27 43 PM

Comment on lines 129 to 133
If you’re collecting activity logs from one event hub instance,
then only 2 threads are required.

* Event Hubs = 1
* Threads = 2 (1 Event Hub + 1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbavey this PR is my attempt to capture the formatting changes I was working on. IIRC you said that this content from the current docs is not 100% accurate. Can we make some easy adjustments to correct the content and get this over the finish line?

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karenzone karenzone merged commit 64e90a5 into logstash-plugins:main Jun 7, 2024
1 of 2 checks passed
@karenzone karenzone deleted the 89-format-scenarios branch June 7, 2024 13:58
@karenzone
Copy link
Contributor Author

Published to rubygems.org at v1.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Format examples for easier parsing
3 participants