Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change warnings to info, increase time between messages #2211

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: change warnings to info, increase time between messages #2211

merged 1 commit into from
Oct 10, 2024

Conversation

zerbitx
Copy link
Contributor

@zerbitx zerbitx commented Oct 8, 2024 •
edited
Loading

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

resolves #ENG-4817

@zerbitx zerbitx marked this pull request as draft October 8, 2024 13:23
@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a32bb30
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6707079a8dab4500088b2648

@zerbitx zerbitx marked this pull request as ready for review October 8, 2024 14:00
@zerbitx zerbitx requested a review from a team October 8, 2024 14:00
lizardruss
lizardruss previously requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible change to make the usage of defaultPollInterval consistent

pkg/platform/helper.go Outdated Show resolved Hide resolved
pkg/platform/helper.go Outdated Show resolved Hide resolved
@zerbitx
fix: change warnings to info
a32bb30 
ups the default poll interval from 20 seconds to 40
@FabianKramm FabianKramm merged commit 05a5788 into loft-sh:main Oct 10, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianKramm FabianKramm FabianKramm approved these changes

@lizardruss lizardruss Awaiting requested review from lizardruss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerbitx @lizardruss @FabianKramm