WIP fix/implement caching upstream #93 #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For read-through caching, queries to registration and package service must be directed to upstream server. Otherwise client would get always 404 because there is nothing in the cache to begin with. We can add caching queries too, but that requires integrating catalog reader to refresh responses for already cached packages.
Closed
loic-sharma
reviewed
Sep 28, 2018
| @@ -9,6 +11,19 @@ namespace BaGet.Core.Mirror | |||
| /// </summary> | |||
| public class FakeMirrorService : IMirrorService | |||
| { | |||
| Task<IReadOnlyList<string>> emptyVersions = Task.Factory.StartNew(() => new List<string>() as IReadOnlyList<string>); | |||
There was a problem hiding this comment.
Instead of Task.Factory.StartNew, how about Task.FromResult?
|
Thank you for tackling this! I think your current solution has a flaw. Say package
This is a tough problem to solve. A possible solution may be to always contact the upstream source. This may be feasible as the NuGet client caches HTTP responses. What're your thoughts @tomzo? |
loic-sharma
reviewed
Sep 28, 2018
| HasReadme = false; // | ||
| IconUrl = NullSafeToString(package.IconUrl); | ||
| Language = null; // | ||
| LicenseUrl = NullSafeToString(package.LicenseUrl); |
There was a problem hiding this comment.
What about just package.LicenseUrl?.ToString();?
Second endpoint would solve that too.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For read-through caching, queries to registration and package service
must be directed to upstream server. Otherwise client would get always
404 because there is nothing in the cache to begin with.
We can add caching queries too, but that requires integrating catalog
reader to refresh responses for already cached packages.
What does this PR do?
Fixes read-through cache.
Closes Issue(s)
#93
Additional Notes
"PackageSource": "https://api.nuget.org/v3-flatcontainer/". I think we need to specify full URL to the index of nuget server. Such as"https://api.nuget.org/v3/index.json".