UT RE - enable for timer util #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: pytorch#506 # Context [Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.] # This diff [List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.] # What’s next [If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.] Differential Revision: D48475432 fbshipit-source-id: 110a21e6dc08eaadb7ddd5055385193d9ea9ef1b
e57eeb5
to
4cad22f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 19, 2023
Summary: Pull Request resolved: pytorch#506 # Context [Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.] # This diff [List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.] # What’s next [If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.] Differential Revision: D48475432 fbshipit-source-id: 1c4ec8fab84f80fc96bb03e0e0ea24ca7906dabc
4cad22f
to
3397e6f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 19, 2023
Summary: Pull Request resolved: pytorch#506 # Context [Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.] # This diff [List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.] # What’s next [If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.] Differential Revision: D48475432 fbshipit-source-id: 607d36d9596b964e59143374f8b92ae4ca9f9b8b
3397e6f
to
efab620
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
galrotem
added a commit
to galrotem/tnt
that referenced
this pull request
Aug 19, 2023
Summary: Pull Request resolved: pytorch#506 # Context [Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.] # This diff [List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.] # What’s next [If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.] Differential Revision: D48475432 fbshipit-source-id: 7d4e4f0b33b85bc215534e142628c111ef0edb7d
efab620
to
590e13d
Compare
Summary: Pull Request resolved: pytorch#506 # Context [Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.] # This diff [List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.] # What’s next [If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.] Differential Revision: D48475432 fbshipit-source-id: 072f66e215fc261871f5bcbf90f93120f50fa5e5
|
This pull request was exported from Phabricator. Differential Revision: D48475432 |
590e13d
to
c79d026
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 86.95% 86.92% -0.04%
==========================================
Files 106 106
Lines 8407 8395 -12
==========================================
- Hits 7310 7297 -13
- Misses 1097 1098 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
[Describe motivations and existing situation that led to creating this diff. Don't be cheap with context, it is the basis for a good code review.]
This diff
[List all the changes that this diff introduces and explain the ones that are not trivial. Give directions for the reviewer if needed.]
What’s next
[If this diff is part of a stack or if it has direct continuation in a future diff, share these plans with your reviewer.]
Differential Revision: D48475432