Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/DOC: call for Timestamp #5168

Closed
adamgreenhall opened this issue Oct 10, 2013 · 8 comments · Fixed by #18033
Closed

ENH/DOC: call for Timestamp #5168

adamgreenhall opened this issue Oct 10, 2013 · 8 comments · Fixed by #18033
Labels
Bug Docs Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Milestone

Comments

@adamgreenhall
Copy link
Contributor

When you create a timestamp with a timezone and don't use a keyword argument, it fails silently:

>> pd.Timestamp('2012-01-01', 'US/Pacific')
Timestamp('2012-01-01 00:00:00', tz=None)
@cpcloud
Copy link
Member

cpcloud commented Oct 10, 2013

The second argument is not the timezone, it's the offset. This could maybe use some better documentation if that wasn't already clear somewhere in the docs.

@cpcloud
Copy link
Member

cpcloud commented Oct 10, 2013

Thought ideally, it should fail in this case and not just continue on

@adamgreenhall
Copy link
Contributor Author

I agree. I don't see an example of creating a standalone pd.Timestamp in the current docs. The docstring could also use some mention of which arguments the function takes.

@jreback
Copy link
Contributor

jreback commented Oct 10, 2013

here
(or in the first section, whatever looks more natural), an example of using Timestamp would be nice

would welcome a PR & docstring update!

@jreback
Copy link
Contributor

jreback commented Feb 6, 2014

@adamgreenhall want to do some docs / example for Timestamp?

maybe update the doc string as well

Timestamp has a different constructor than datetime need to show that

@jorisvandenbossche
Copy link
Member

However, there is a problem with documenting Timestamp in the api docs, see #5218. But of course, you can already update the docstring for intereactive use, or start to add a section in the narrative docs.

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Apr 9, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Oct 22, 2017
@jbrockmendel
Copy link
Member

Is this handled by #17943, or is there a distinct issue?

@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

yep, want to add a validation test to close this?

@jreback jreback modified the milestones: Next Major Release, 0.22.0 Oct 29, 2017
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Oct 30, 2017
jreback pushed a commit that referenced this issue Oct 31, 2017
peterpanmj pushed a commit to peterpanmj/pandas that referenced this issue Oct 31, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Docs Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants