Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate cols / change to subset in duplicated/drop_duplicates #6680

Closed
jreback opened this issue Mar 21, 2014 · 4 comments
Closed

DEPR: deprecate cols / change to subset in duplicated/drop_duplicates #6680

jreback opened this issue Mar 21, 2014 · 4 comments
Labels
Deprecate Functionality to remove in pandas
Milestone
0.14.0

Comments

@jreback
Copy link
Contributor

jreback commented Mar 21, 2014

for consistency with dropna (and also to not use cols which is being deprecated)

related #6645
@jreback jreback added this to the 0.14.0 milestone Mar 21, 2014
@jreback jreback changed the title DEPR: change cols to subset in duplicated/drop_duplicates DEPR: deprecate cols / change to subset in duplicated/drop_duplicates Mar 21, 2014
@jreback jreback mentioned this issue Mar 22, 2014
Closed
@jsexauer jsexauer mentioned this issue Mar 22, 2014
Closed
1 task
@jsexauer
Copy link
Contributor

In working on this, the only unit tests I could find for duplicated where in pandas/tseries/tests/test_timeseries.py. Shouldn't there be some tests in pandas/tests/test_frame.py? Regardless, where would you like to see the unit test the verifies the warnings are errors are raised as expected?

@jsexauer
Copy link
Contributor

Also, can I please assigned to this so I can convert this issue into a pr? Thanks.

@jreback
Copy link
Contributor Author

jreback commented Mar 23, 2014

go ahead

hmm should be some tests for duplicated/drop_duplicates in test_frame

if not prob just the underlying routines see tested

pls add a suite of tests (including the depr warning tests)

thanks

@jsexauer jsexauer mentioned this issue Mar 23, 2014
Closed
@jreback
Copy link
Contributor Author

jreback commented Mar 25, 2014

closed by #6693

@jreback jreback closed this as completed Mar 25, 2014
@jreback jreback mentioned this issue Apr 24, 2014
Closed
jreback added a commit to jreback/pandas that referenced this issue Jan 28, 2016
@jreback
DEPR: Removal of cols keyword in favor of subset in DataFrame.duplica…
e3579a5 
…ted() and DataFrame.drop_duplicates(), xref pandas-dev#6680
@jreback jreback mentioned this issue Jan 28, 2016
Closed
jreback added a commit that referenced this issue Jan 28, 2016
@jreback
DEPR: some removals
bb94ebe 
DEPR: Removal of cols keyword in favor of subset in
DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680

Author: Jeff Reback <jeff@reback.net>

Closes #12165 from jreback/deprecate and squashes the following commits:

5be6dc6 [Jeff Reback] DOC: small fix on Timestamp doc-string
e3579a5 [Jeff Reback] DEPR: Removal of cols keyword in favor of subset in DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680
@jreback jreback mentioned this issue Jul 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

DEPR: Deprecate cols in several functions jsexauer/pandas
2 participants
@jreback @jsexauer