Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote data access: World Bank #8482

Closed
DaveBackus opened this issue Oct 6, 2014 · 11 comments · Fixed by #8551
Closed

Remote data access: World Bank #8482

DaveBackus opened this issue Oct 6, 2014 · 11 comments · Fixed by #8551
Milestone

Comments

@DaveBackus
Copy link

A minor issue: The function in pandas.io.data uses 2-letter codes to identify countries in data requests, rather than the more common 3-letter codes. The latter is closer to the social norm at the iMF, World Bank, etc. More important, they're easier to track down. If you download the World Bank data (all of it), the data includes country names and 3-letter codes, but not 2-letter codes. So to me the 3-letter codes would be more user-friendly.

Cheers.

http://pandas.pydata.org/pandas-docs/stable/remote_data.html#world-bank

@jreback
Copy link
Contributor

jreback commented Oct 6, 2014

this prob could be added pretty easily (and accept both 2/3 letter codes). interested in doing a pull-request?

@jreback jreback added this to the Someday milestone Oct 6, 2014
@DaveBackus
Copy link
Author

Interesting idea, I'll give it a try. I'm a newbie, though, making a
transition from Matlab and R.

On Mon, Oct 6, 2014 at 8:51 AM, jreback notifications@github.com wrote:

this prob could be added pretty easily (and accept both 2/3 letter codes).
interested in doing a pull-request?


Reply to this email directly or view it on GitHub
#8482 (comment).

@jreback
Copy link
Contributor

jreback commented Oct 6, 2014

np. always welcome new contributors, see here for help: https://github.com/pydata/pandas/wiki

@DaveBackus
Copy link
Author

Cool, thank you. I may have some candidates for the Cookbook in a month or
two.

More at https://github.com/DaveBackus/Data_Bootcamp

On Mon, Oct 6, 2014 at 10:58 AM, jreback notifications@github.com wrote:

np. always welcome new contributors, see here for help:
https://github.com/pydata/pandas/wiki


Reply to this email directly or view it on GitHub
#8482 (comment).

@jnmclarty
Copy link
Contributor

Dave, if you don't do a PR for this, I could probably tackle it. Let me know if you want help.

@DaveBackus
Copy link
Author

Hi Jeff,

It'll be a while till I get to this, feel free to charge ahead.

Dave

On Fri, Oct 10, 2014 at 8:05 PM, Jeffrey McLarty notifications@github.com
wrote:

Dave, if you don't do a PR for this, I could probably tackle it. Let me
know if you want help.


Reply to this email directly or view it on GitHub
#8482 (comment).

@jnmclarty
Copy link
Contributor

@jreback
The enhancement is done, just need to see how I go about testing it, and writing a test (if I need to?), and then update the right 'what's new' after I figure out which pandas version it would go into. 0.15.1? or 0.16? The change is trivial, however it is technically an API change.

@DaveBackus If you really want the feature sooner, you could copy and paste wb.py into your sitepackage/pandas/io folder.

Edit: Removed note about PEP8. Done.

@DaveBackus
Copy link
Author

Perfect, thanks a lot.

On Mon, Oct 13, 2014 at 3:37 PM, Jeffrey McLarty notifications@github.com
wrote:

@jreback https://github.com/jreback
The enhancement is done, just need to see how I go about testing it, and
writing a test (if I need to?), and then update the right 'what's new'
after I figure out which pandas version it would go into. 0.15.1? or 0.16?
The change is trivial, however it is technically an API change. Also need
to pep8.

@DaveBackus https://github.com/DaveBackus If you really want the
feature sooner, you could copy and paste wb.py into your
sitepackage/pandas/io folder.


Reply to this email directly or view it on GitHub
#8482 (comment).

@jnmclarty
Copy link
Contributor

Oh - now I know what people mean about the effect of multiple rebases/squashes referencing Issue numbers.

Anywho, @DaveBackus want to close this? The feature will be in 0.15.1

@jreback
Copy link
Contributor

jreback commented Oct 25, 2014

@jnmclarty this will be automatically closed when we merge the associated pr

@DaveBackus
Copy link
Author

Perfect. Thanks a lot to everyone.

On Sat, Oct 25, 2014 at 11:55 AM, jreback notifications@github.com wrote:

@jnmclarty https://github.com/jnmclarty this will be automatically
closed when we merge the associated pr


Reply to this email directly or view it on GitHub
#8482 (comment).

@jreback jreback removed this from the 0.15.2 milestone Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants