More context for EOF during client setup #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The secsh-filexfer-02 document is silent about what to do in this case. I think however the error |
I agree |
drakkan
reviewed
Jul 11, 2022
client.go
Outdated
| @@ -267,8 +275,13 @@ func (c *Client) nextID() uint32 { | |||
| func (c *Client) recvVersion() error { | |||
| typ, data, err := c.recvPacket(0) | |||
| if err != nil { | |||
| if err == io.EOF { | |||
| return io.ErrUnexpectedEOF | |||
There was a problem hiding this comment.
Maybe we could do something like this here
return fmt.Errorf("server unexpectedly closed connection: %w", io.ErrUnexpectedEOF)
so errors.Is(err, io.ErrUnexpectedEOF) will work
|
Alright, I think we’re good now. 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns raised from #506 where a bare EOF was being returned, and thus being quite unclear about where the EOF happened.
This adds more context to the returned errors, and replaces
EOFwithUnexpectedEOFsince we definitely aren’t expecting one.However, I’m thinking a better message should be returned than even unexpected EOF. I’ll be digging through documentation to see what the best option here is.