Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README in dark mode #232

Closed
dferber90 opened this issue Dec 11, 2020 · 1 comment
Closed

README in dark mode #232

dferber90 opened this issue Dec 11, 2020 · 1 comment

Comments

@dferber90
Copy link

I noticed you've got a highly polished README, which looks quite impressive! Well done :)

I noticed it uses images as headlines. GitHub recently introduced dark mode. Unfortunately the images-approach doesn't work well with dark mode as pictured below.

image

I don't use jotai and I just stumbled upon your README by chance (in dark mode), but I thought I'd share an alternative approach that might work for you (in both, dark mode and regular mode) in case you're not familiar with it.

The repo sindresorhus/css-in-readme-like-wat shows how you can embed CSS into SVGs using foreignObject. A PR using that technique can be seen here: sindresorhus/sindresorhus#9.

I think this might help resolve the approach coming from using images only. Not sure how well it would work with READMEs displayed on npm.

In any case, I only opened this issue to let you know about a cool potential solution. This is only meant as a "hey, check this out, this might be useful". Feel free to close the issue.

@dai-shi
Copy link
Member

dai-shi commented Dec 11, 2020

Hey, thanks for dropping by. Hope you eventually try jotai too!
We are discussing about the dark mode including foreignObject. Will see how it goes.
In the long term, we would eventually migrate to a new web site.

@dai-shi dai-shi closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants