Try to load the content for 10 seconds #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Closed
|
Haha. Clever. |
|
Does it actually work though? Doesn't seem to render here: https://github.com/Richienb/sindresorhus/tree/try-load |
|
@sindresorhus That's because it depends on the image being located in your repository https://github.com/sindresorhus/sindresorhus/pull/9/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9R2 |
|
The links no longer work though, since clicking it just links the image. Maybe you could linkify the image to https://www.youtube.com/watch?v=dQw4w9WgXcQ ? |
|
@sindresorhus Replace the img tag in the readme with <a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ"><img src="https://github.com/sindresorhus/sindresorhus/raw/master/info.svg?sanitize=true"></a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to load the readme content for 10 seconds before giving up.
Preview
// @sindresorhus