Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectPanel] Fix tab index issue in multi-select mode #3077

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Sep 11, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

@kendallgassner discovered a bug in the SelectPanel component affecting keyboard navigation for multi-select panels. Steps to reproduce:

  1. Open the panel and focus on the filter input. Press Tab.
  2. Observe that focus moves to the first item.
  3. Focus on the filter input and enter text that causes the first item to be hidden, i.e. be filtered out.
  4. Clear the filter input and press Tab.
  5. Observe that focus does not move to the first item (which is unexpected).

Screenshots

Video alt: A screen recording demonstrating that the first item is initially tabbable but cannot be reached after filtering.

Screen.Recording.2024-09-11.at.10.06.33.PM.mov

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
    - [ ] Added/updated documentation
    - [ ] Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 30acd0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron changed the title Fix tab index issue in SelectPanel's multi-select mode [SelectPanel] Fix tab index issue in multi-select mode Sep 12, 2024
@camertron
Copy link
Contributor Author

In the interest of time, I'm going to use my admin rights and merge this.

@camertron camertron merged commit 66488a3 into main Sep 12, 2024
37 checks passed
@camertron camertron deleted the multi_select_tab_index_fix branch September 12, 2024 05:32
@primer primer bot mentioned this pull request Sep 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants