Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): expose readonly maven packaging dist dir #2624

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

cogwirrel
Copy link
Contributor

It can be useful to know the location of the dist dir, eg. for setting up local dependencies in a monorepo (ref: aws/aws-pdk#358 )

This change exposes it as a readonly property.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #2624 (575fb28) into main (10dbea5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2624   +/-   ##
=======================================
  Coverage   96.21%   96.22%           
=======================================
  Files         181      181           
  Lines       32699    32704    +5     
  Branches     2956     2956           
=======================================
+ Hits        31461    31468    +7     
+ Misses       1238     1236    -2     
Impacted Files Coverage Δ
src/java/maven-packaging.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cogwirrel cogwirrel force-pushed the feat/expose-maven-packaging-distdir branch from c33eac8 to 575fb28 Compare April 21, 2023 01:57
@mergify mergify bot merged commit 1d95408 into projen:main Apr 21, 2023
@cogwirrel
Copy link
Contributor Author

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants