fix(poetry): maintain frozen lockfile for install task #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the poetry install task from `poetry update` to `poetry lock --no-update && poetry install` to ensure that the lockfile is honoured in CI/CD pipelines. Post synthesis, run a "mutable install" (`poetry lock && poetry install`) task which updates the lockfile, if the pyproject.toml file has changed (ie dependencies were changed). Add a new `upgrade` task which runs `poetry update` to update dependencies. Fixes projen#2913
ef6a6f1
to
87ca38a
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
- Coverage 96.29% 96.28% -0.01%
==========================================
Files 191 191
Lines 36750 36780 +30
Branches 3440 3441 +1
==========================================
+ Hits 35388 35415 +27
- Misses 1362 1365 +3 ☔ View full report in Codecov by Sentry. |
|
Nice one! Can we swap the naming around here to mirror what we have for Node? |
Thanks! Good call - updated! 😄 |
mrgrain
approved these changes
Feb 13, 2024
|
Thanks Momo! 😄 |
cogwirrel
added a commit
to aws/aws-pdk
that referenced
this pull request
Feb 15, 2024
…docs Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying package manager. Add upgrade-deps taks for the python and java monorepos for consistency, which spawn the "upgrade" tasks (if present) for subprojects. Added documentation for upgrading dependencies. This also updates the projen version which includes a fix to ensure the python install task doesn't upgrade dependencies: projen/projen#3321 Fixes #653
cogwirrel
added a commit
to aws/aws-pdk
that referenced
this pull request
Feb 15, 2024
…docs Fix the `pdk upgrade` command to call the projen task rather than the command for the underlying package manager. Add `upgrade-deps` tasks for the Python and Java monorepos for consistency, which spawn the "upgrade" tasks (if present) for subprojects. Also update the `upgrade-deps` task for the TypeScript monorepo to spawn the "upgrade" task for any non-node project. Added documentation for upgrading dependencies. This also updates the projen version which includes a fix to ensure the python install task doesn't upgrade dependencies: projen/projen#3321 Fixes #653
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the poetry install task from
poetry updatetopoetry lock --no-update && poetry installto ensure that the lockfile is honoured in CI/CD pipelines.Post synthesis, run a "mutable install" (
poetry lock && poetry install) task which updates the lockfile, if the pyproject.toml file has changed (ie dependencies were changed).Add a new
upgradetask which runspoetry updateto update dependencies.Fixes #2913
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.