multi-dimensional indexing is deprecated in pandas. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richafrank
reviewed
Oct 8, 2020
There was a problem hiding this comment.
Thanks @cgdeboer ! Makes sense to me. I suggested what I think is a simpler implementation, but let me know what you think, or if it doesn't work for some reason.
Co-authored-by: Richard Frank <richafrank@users.noreply.github.com>
Co-authored-by: Richard Frank <richafrank@users.noreply.github.com>
|
@richafrank looks like the last tagged version was Aug of last year. When do you and team anticipate cutting a new version, with this PR included ? |
It looks like the most recent tagged version was June of this year (0.5.4), but the team never made a release. I just made a release for that, and I'll do the same after merging this. |
|
@cgdeboer 0.5.5 is released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas is removing this
[:, x]style of multi-dimension indexer. (pandas-dev/pandas#27837).This converts pandas Series to an array to ensure API is compliant with updates to Pandas.