Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2119] Add notes to followups #2206

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

rhian-cs
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #2119

What changed, and why?

Followups now have a note attribute associated with them. Admins, supervisors and volunteers can write an optional note when creating a followup for a given case contact by interacting with a Swal alert.

How will this affect user permissions?

No permissions will be affected. All users that can create followups can add notes to them.

How is this tested? (please write tests!) 💖💪

Manual testing:

  • Go a case page or the case contacts page
  • Click on the "Followup" button of a given contact
  • Check if the close and cancel button are working properly
  • Check if adding a followup with and without a note work properly
  • Go (as another user) to the notifications page
  • Check if the notifications with and without notes display properly

Automated testing:

I've added the following specs:

  • Request specs to see if the followups are being created properly and accepts the correct parameters
  • System specs for the followups, to see if the Swal works properly (confirm, cancel and close button behave as expected)
  • System specs for the notifications, to see if followups with and without notes are being displayed properly

Screenshots please :)

When an user clicks on the "Follow up" button the Swal displays the following prompt:
03-prompt

The notifications page now displays followups with and without notes:
01-notifications

Mobile view of notifications page:
02-notifications-mobile

@github-actions github-actions bot added erb javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jun 28, 2021
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! :)

@compwron compwron merged commit c6da9e5 into rubyforgood:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Supervisor or Volunteer or Admin to add a note to a Follow Up
2 participants