Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2286] Display archived contacts differently in order to highlight them #2298

Merged

Conversation

rhian-cs
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #2286

What changed, and why?

The pages with case contacts now display archived contacts differently, compared to the active contacts.

Archived contacts now display in grey, with an (Archived) text at the end, and with a tooltip beside them with the text: "Archived contacts can't be edited. Case contacts are archived after the end of each quarter.".

How will this affect user permissions?

No permissions will be affected.

How is this tested? (please write tests!) 💖💪

I've added system specs to check the CSS of each contact, and whether or not the tooltip is actually displayed.

Screenshots please :)

Desktop view

01

Mobile view

02

Archived Tooltip

03

@github-actions github-actions bot added erb ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jul 20, 2021
@rhian-cs rhian-cs force-pushed the 2286-highlight-archived-case-contacts branch from 043ce32 to 818b6ad Compare July 20, 2021 17:50
@compwron compwron merged commit 14b8403 into rubyforgood:main Jul 22, 2021
@rhian-cs rhian-cs deleted the 2286-highlight-archived-case-contacts branch August 5, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make archived case contacts more obvious.
2 participants