[#2957] Add .webp to casa org logo accepted extensions #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mauricio Lima <mauricio.prl42@gmail.com>
compwron
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #2957
What changed, and why?
In the organization edit page (
/casa_org/1/edit), the admin can now add a.webplogo.How will this affect user permissions?
No permissions will be affected.
How is this tested? (please write tests!) 💖💪
Unfortunately, I can't add a test to check if different extensions work. When using the
page.attach_filemethod any file will work, since theaccept: ".png,.gif,.jpg,.jpeg,.webp"only tells the browser which files to show in the file selection menu.We could also validate the file format (extension or MIME type) in the backend, if it is of any interest. It would also be easier to test.
Screenshots please :)
When clicking the Logo "Choose File" button:
Before:
.webpfiles did not show up in the "Open file" windowAfter:
.webpfiles now show up in the window