Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Additional polish for jobs and progress bar #34551

Merged
merged 16 commits into from
Apr 26, 2023
Merged

[Dashboard] Additional polish for jobs and progress bar #34551

merged 16 commits into from
Apr 26, 2023

Conversation

alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Apr 18, 2023 •
edited
Loading

Why are these changes needed?

  • Fix progress bar not showing loading bars on first load.
  • Fix progress bar showing unloaded data when we have loaded data already cached
  • Add spinnner and icons next to job status in jobs table and job detail page
  • Fix progress bar using total tasks across all jobs instead of tasks specific to a single job

Screenshot 2023-04-25 at 5 00 46 PM

Screenshot 2023-04-25 at 5 00 52 PM

Related issue number

Stacked commit on top of #19629

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alanwguo
Add driver logs to Jobs page for submission jobs
d24ecd0 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Update styling
96d313a 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Add refresh button
25e1ca0 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Add job metadata to the job detail page
0e13d62 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
small polish items
53040da 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fix "autoscaler" section of job detail page.
585deb5 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fixup
c40f4f0 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fixup
e036ebb 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fixup
e9e42b1 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fixup
ff18965 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Fix progress bar not showing loading bars on first load.
e8928d1 
Fix progress bar showing unloaded data when we have loaded data already cached
Add spinnner and icons next to job status in jobs table and job detail page

Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Merge branch 'master' into job-loading-polish
3a5e8e7
@alanwguo
Add rayMeta to serve_grafana_dashboard also
8741b6a 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo alanwguo marked this pull request as ready for review April 24, 2023 22:34
@chaowanggg chaowanggg self-requested a review April 25, 2023 00:57
chaowanggg
chaowanggg approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@chaowanggg chaowanggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rkooo567
Copy link
Contributor

I will merge it once @scottsun94 approves

@scottsun94
Copy link
Contributor

scottsun94 commented Apr 25, 2023 •
edited
Loading

Only have 1 question: If we put the spinner into the status box, will it make it hard to maintain the consistency of the "Running" status box (in other tables, like task table, we probably don't want add spinner since it could be distracting when a lot of tasks are running) ?

Screen Shot 2023-04-24 at 10 35 34 PM

@alanwguo
Copy link
Contributor Author

Only have 1 question: If we put the spinner into the status box, will it make it hard to maintain the consistency of the "Running" status box (in other tables, like task table, we probably don't want add spinner since it could be distracting when a lot of tasks are running) ?

Screen Shot 2023-04-24 at 10 35 34 PM

We can change the styling to look like that without adding them to all the pages. It can be an option like "withIcon=true"

@scottsun94
Copy link
Contributor

We can change the styling to look like that without adding them to all the pages. It can be an option like "withIcon=true"

Cool. Can we put the spinner into the box then? Here is a simple spec.
Screen Shot 2023-04-25 at 2 32 30 PM

@alanwguo
fix serve application detail page erroring when no replicas exist
3cc692d 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
fixup
92f52d7 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo
Copy link
Contributor Author

We can change the styling to look like that without adding them to all the pages. It can be an option like "withIcon=true"

Cool. Can we put the spinner into the box then? Here is a simple spec. Screen Shot 2023-04-25 at 2 32 30 PM

Updated, please take another look

@scottsun94
Copy link
Contributor

LGTM. Thanks!

@alanwguo
Copy link
Contributor Author

@rkooo567 please merge!

@alanwguo
fixup
6fb0349 
Signed-off-by: Alan Guo <aguo@anyscale.com>
@rkooo567
Copy link
Contributor

Let me wait for the build haha

@rkooo567 rkooo567 merged commit e247779 into ray-project:master Apr 26, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@alanwguo @ProjectsByJackHe
[Dashboard] Additional polish for jobs and progress bar (ray-project#…
0786186 
…34551)

- Fix progress bar not showing loading bars on first load.
- Fix progress bar showing unloaded data when we have loaded data already cached
- Add spinnner and icons next to job status in jobs table and job detail page
- Fix progress bar using total tasks across all jobs instead of tasks specific to a single job

Signed-off-by: Jack He <jackhe2345@gmail.com>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@alanwguo @architkulkarni
[Dashboard] Additional polish for jobs and progress bar (ray-project#…
ff4053a 
…34551)

- Fix progress bar not showing loading bars on first load.
- Fix progress bar showing unloaded data when we have loaded data already cached
- Add spinnner and icons next to job status in jobs table and job detail page
- Fix progress bar using total tasks across all jobs instead of tasks specific to a single job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaowanggg chaowanggg chaowanggg approved these changes

Assignees

@scottsun94 scottsun94

@rkooo567 rkooo567

@chaowanggg chaowanggg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanwguo @rkooo567 @scottsun94 @chaowanggg