Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databasemanager: support more frequency meta term bank formats #237

Merged

Conversation

precondition
Copy link
Contributor

The database manager was assuming that the blobs related to the term frequency all exclusively follow this format:

[
    "<term>","freq",
    {"reading":"<reading>",
       "frequency": {"value": <number>, "displayValue": "<stylized frequency string>"}
    }
]

However, the dictionary-term-meta-bank-v3-schema allows for multiple possible types for the value of the frequency key.

This pull request adds support for all possible types of frequency so that the pop-up can show frequency information for the highlighted term.

@ripose-jp
Copy link
Owner

Excellent code and comments. Thank you for finding this.

@ripose-jp ripose-jp merged commit 271c657 into ripose-jp:master Aug 29, 2024
3 checks passed
@precondition precondition deleted the better_freq_meta_term_bank_support branch August 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants