This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Fix exposed ports accessible from localhost only, fixes #3886 #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insidewhy
commented
Jan 1, 2018
| @@ -233,7 +233,7 @@ func (e *podEnv) portFwdChain(name string) string { | |||
| func (e *podEnv) portFwdChainRuleSpec(chain string, name string) []string { | |||
| switch name { | |||
| case "SNAT": | |||
| return []string{"-s", "127.0.0.1", "!", "-d", "127.0.0.1", "-j", chain} | |||
| return []string{"!", "-d", "127.0.0.1", "-j", chain} | |||
There was a problem hiding this comment.
The source was set here as well as in the chain... different masquerade rules might have different dstIPHost's within the same chain though so seems best just to remove it from this rule.
|
This solution doesn't seem to work but I'm throwing it out there for now as I really need help fixing this. I'm just really not sure how useful rkt can be to me if it can only expose ports to localhost and I'm pretty surprised it's been this way for so long. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #3886, it doesn't work yet but I need some support/acknowledgment on this issue.