add support to import image from docker-daemon in rkt #3939
Conversation
|
This PR first fetches the image from machine's running docker daemon into a tar format. This is similar to running a Then it is converted into |
4e78b87
to
72d6995
Compare
Now you can import an image that is available in docker's image store on a local machine into rkt's imagestore. To do so run following command: ``` rkt fetch --insecure-options=image docker-daemon://docker.io/library/alpine ``` or directly run it the usual way ``` rkt run --insecure-options=image docker-daemon://docker.io/library/alpine ``` This will import the image `docker.io/library/alpine` into rkt's store.
72d6995
to
8891832
Compare
| if err != nil { | ||
| return "", err | ||
| } | ||
| defer aciCleaner() |
There was a problem hiding this comment.
aciCleaner() called twice? (line 45 and 52)
|
That's a nice change to automatically invoke equivalent of two commands ( However I recommend not to merge it as it is, for numerous reasons:
|
Add support to import image from docker-daemon in rkt
Now you can import an image that is available in docker's image store on
a local machine into rkt's imagestore.
To do so run following command:
or directly run it the usual way
This will import the image
docker.io/library/alpineinto rkt's store.