This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Expose raw ports using docker2aci style port syntax #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @squeed |
|
Hi @lucab I see you've looked at a few PRs trying to add raw ports to rkt before -- do you have some time to look at this with me? Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was created to allow ports to be exposed without being in the image manifest. It uses the same syntax as generated manifests from docker2aci (e.g. '80-tcp', etc). Motivation is for running Envoy as a sidecar -- which discovers the ports it listens on at run-time rather than at image build time.
Happy to add tests + docs or change strategy if desired. I wanted to use OCI syntax as suggested in #2113 but this requires a change to ACName. The advantage of that approach is not overloading the docker syntax -- wherein people may get confused that a docker image port has changed and they no longer get an error but instead have exposed a raw port. I'm happy to pursue that route as well.
I'm not opposed to other strategies such as #3407 but am concerned it appeared to have died on the vine. Rkt's native pod support is an excellent feature for doing sidecars right at the runtime layer and I really want to see service mesh sidecars like Envoy compatible with Rkt.