Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_result for 2024 exam #197

Open
johannes-titz opened this issue Jun 5, 2024 · 14 comments
Open

extract_result for 2024 exam #197

johannes-titz opened this issue Jun 5, 2024 · 14 comments

Comments

@johannes-titz
Copy link
Collaborator

Calling extract_results("data-raw/mlehreI2024TEST.zip", "items") on 2024 exam gives:

Error in data.frame(file = rep(file_name, length(identifier)), date = rep(test_dt,  : 
  arguments imply differing number of rows: 48, 40

Works for other exams.

I think you have access to the 2024 exam, right?

@shevandrin
Copy link
Owner

shevandrin commented Jun 5, 2024

I have checked the exams platform, I looked at Methodenlehre I, but I could not find where i can download zip

@johannes-titz
Copy link
Collaborator Author

On tucexam? You must go to "Bewertungen" and then on the right-hand-side there should be some export; alternatively go to archive. It is a bit hidden.

@shevandrin
Copy link
Owner

shevandrin commented Jun 5, 2024

I think it is due to "lagemaßeDavisS2024", german letter in file name, it gives a problem with unzipping

@johannes-titz
Copy link
Collaborator Author

johannes-titz commented Jun 5, 2024

Oh no; once again, I guess I forgot about that. Can we give a meaningful error?

@shevandrin
Copy link
Owner

there is another issue, i am working on it

@shevandrin
Copy link
Owner

The problem was with results for Ordering type, when candidate did not provide the answer at all. I have fixed it.
Can you check again and give me your error message now?

@johannes-titz
Copy link
Collaborator Author

Great! Works for me. Is this an additional problem to ß? Or was ß not a problem in the first place?

@shevandrin
Copy link
Owner

if you do not have an error, it means that problems with german letters are only on my side (i think due to win)

@shevandrin
Copy link
Owner

Great! Works for me. Is this an additional problem to ß? Or was ß not a problem in the first place?

i had both errors: 1) with incorrect parsing Ordering outcomes 2) with german letter in file name.
The first is solved, the second i still have

@johannes-titz
Copy link
Collaborator Author

I have no errors. Ok, I see. Would it be an option to replace these values during processing? I am not so much concerned for our data since we stopped using umlauts, but for old data or other people's data it could still be a problem. If it is not possible, we could just give a more meaningful error message. It is not high priority though.

@shevandrin
Copy link
Owner

shevandrin commented Jun 6, 2024

I added checker that stops processing and gives a file name. Can you launch it again? I am curious would it give you an error or not? If it stops on your side, I change checker to warning message

@johannes-titz
Copy link
Collaborator Author

I get no error.

@shevandrin
Copy link
Owner

image
in cases like mine a user gets this message
we can close this

@johannes-titz
Copy link
Collaborator Author

We could leave it open; if we have time we can try to rename the files automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants