-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Create Menu Item
Action
#144
Conversation
I figured out a way to implement this without using the contact hack. A user can currently choose between Emoji and SF Symbol for the icon as well as apply a background and foreground (only symbol) color @sindresorhus is there a requirement for using a single app per Action? |
Thanks for working on this 👍 |
By "app", do you mean "file". If so, yes, I would prefer to keep an action and related types in one file. Otherwise it simply ends up being too many files. |
Code should be tab-indented. |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
You have many lint warnings. See the diff. |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
readme should also updated at section |
I won't be able to try this out until Xcode 15 RC is out, probably in a week. |
You need to resolve the merge conflict. |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Conflicts: .gitignore Actions.xcodeproj/project.pbxproj Config.xcconfig
remove progressive disclosure in summary
Conflicts: Config.xcconfig
Thanks :) |
Btw, this still required substantial clean up: 5455817 In case you are interested in seeing what to improve upon. It was easier to do it afterwards than to comment on everything. I also found a bunch of minor bugs. Some things here are just based on my preference though. |
Fixes #141
To Do