Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emptied lines instead of emptying only the contents of the line #664

Open
Bennet-Sunder opened this issue May 21, 2024 · 1 comment

Comments

@Bennet-Sunder
Copy link
Contributor

image (1)

Polyglot piranha currently empties a line instead of removing this line. This means we will have to manually delete all such blank lines post polyglot execution.

Running linters might not be straightforward on larger repositories as it might cleanup unmodified lines as well leading to a huge diff.

@Bennet-Sunder
Copy link
Contributor Author

@ketkarameya could you pls assign this to me, I'll have a look at fixing this.

stefanheule pushed a commit that referenced this issue Sep 2, 2024
Fixes the PR #667 for feature request #664

---------

Co-authored-by: Bennet Sunder <bennet.sunder@freshworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant