Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api-headless-cms-bulk-action): wait for subtasks to finish before cleanup #4331

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Oct 11, 2024

Changes

In this pull request, we are introducing a controller to verify the successful execution of all subtasks triggered by hcmsEntriesEmptyTrashBins. Previously, we were clearing the main task before the subtasks were executed, leading to errors.

How Has This Been Tested?

Manually

@leopuleo leopuleo added this to the 5.41.0 milestone Oct 11, 2024
@leopuleo leopuleo self-assigned this Oct 11, 2024
@leopuleo leopuleo changed the title fix(app-headless-cms-bulk-actions): empty trash bin via background task @leopuleo refactor(api-headless-cms-bulk-action): wait for subtasks to finish before cleanup Oct 15, 2024
@leopuleo leopuleo changed the title @leopuleo refactor(api-headless-cms-bulk-action): wait for subtasks to finish before cleanup refactor(api-headless-cms-bulk-action): wait for subtasks to finish before cleanup Oct 15, 2024
@leopuleo leopuleo merged commit 391a782 into next Oct 16, 2024
100 checks passed
@leopuleo leopuleo deleted the leo/fix/remove-parent-id-empty-trash-bin branch November 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants