Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VersionStream for prometheus-3.0 #34277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding VersionStream for prometheus-3.0 #34277

wants to merge 2 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 15, 2024

No description provided.

Copy link
Contributor Author

octo-sts bot commented Nov 15, 2024

Gen AI suggestions to solve the build error:

Based on the build error output, there are two main issues to address:

  1. Patch Application Failure:
    The patch disable-pprof.patch is failing to apply cleanly, specifically for cmd/prometheus/main.go. This suggests the patch needs to be updated for the new version of Prometheus.

  2. Expected Commit Hash Mismatch:
    The error message indicates the wrong commit hash is being used. You should update the expected-commit in the git-checkout step from:

expected-commit: 68031003375dbfd7f249ec501d0d673d68b2d6d5

to:

expected-commit: c5d009d57fcccb7247e1191a0b10d74b06295388

To fix these issues:

  1. First, update the expected-commit hash as shown above.

  2. For the patch issue, you can:

    • Run the build with --interactive to examine the failed patch
    • Update the patch file by:
      cd /path/to/prometheus/source
      git checkout v3.0.0
      diff -u cmd/prometheus/main.go.orig cmd/prometheus/main.go > new-disable-pprof.patch
    • Or remove the pprof disable functionality if it's no longer needed in v3.0.0

The patch failure is the primary reason for the build failure, and updating both the commit hash and the patch should resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants