Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun #34294

Merged
merged 1 commit into from
Nov 17, 2024
Merged

bun #34294

merged 1 commit into from
Nov 17, 2024

Conversation

xnox
Copy link
Member

@xnox xnox commented Nov 16, 2024

  • New package bun

Copy link
Contributor

octo-sts bot commented Nov 16, 2024

Gen AI suggestions to solve the build error:

Based on the error output, the main issue appears to be that the built binary isn't in the expected location (./build-release/bun). Looking at the build output, it seems the binary was built as bun-profile instead of just bun.

Here are a few suggestions to fix this:

  1. Modify the pipeline command to use the correct binary name:
  - runs: |
      mkdir -p ${{targets.destdir}}/usr/bin
      mv ./build-release/bun-profile ${{targets.destdir}}/usr/bin/bun
  1. Check if the build configuration needs adjustment:
  - runs: |
      # Add this before the build command to see what build options are available
      bun run build --help
      # Then modify the build command if needed
      bun run build:release
  1. Add debug output to verify the build directory contents:
  - runs: |
      ls -la ./build-release/
      mkdir -p ${{targets.destdir}}/usr/bin
      mv ./build-release/bun-profile ${{targets.destdir}}/usr/bin/bun

The most likely solution is the first one - updating the move command to use the correct binary name bun-profile instead of bun. This appears to be how the binary is being built based on the linking step shown in the build output.

If you need to debug this interactively, you can:

  1. Run melange with --interactive
  2. Navigate to the build directory
  3. Check the contents with ls -la build-release/
  4. Verify the binary name and location

@tuananh
Copy link
Contributor

tuananh commented Nov 16, 2024

@xnox it seems we're using 2 conventions here: both bootstrap and stage0 :)

@xnox
Copy link
Member Author

xnox commented Nov 17, 2024

@xnox it seems we're using 2 conventions here: both bootstrap and stage0 :)

I know we don't enforce it at all. But I tend to use stage0 meaning there maybe N other stages; and that package is compiled somehow very differently (less features, less runtime dependencies, statically linked and so on). Whereas bootstrap packages, typically are equivalent, but came compiled from somewhere else. But yeah, it is confusing overall to use more than one name for these things.

@xnox xnox marked this pull request as ready for review November 17, 2024 14:15
@xnox xnox merged commit 288a073 into wolfi-dev:main Nov 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants