[WOIP] Build dotnet-8 using a bootstrap package #33564

ader1990 · 2024-11-07T15:43:13Z

To build dotnet in a more controlled way, I propose to have a bootstrap package and a main package that uses the bootstrap one.

The workflow:

build dotnet-bootstrap-8
build dotnet-source-8

The dotnet-bootstrap-8 package bundles the artifacts from the prep.sh run. Those files consist of:

.dotnet folder - the prep.sh downloads and extracts the following https://dotnetcli.azureedge.net/dotnet/Sdk/8.0.110/dotnet-sdk-8.0.110-linux-x64.tar.gz. The size is ~564MB, License is MIT.
prereqs/packages/archive/Private.SourceBuilt.Artifacts.Bootstrap.tar.gz. This files is a bootstrap resulted from the download and extraction of https://dotnetcli.azureedge.net/source-built-artifacts/assets/Private.SourceBuilt.Artifacts.8.0.110-servicing.24474.1.centos.9-x64.tar.gz (size ~705MB). The bootstrap result is prereqs/packages/archive/Private.SourceBuilt.Artifacts.Bootstrap.tar.gz (~1.4GB). License - this is a very big list of .nupkg, need to check in-depth.

The dotnet-source-8 package uses the bootstrap package and does not need the prep.sh anymore, as the .dotnet folder is symlinked to the bootstrapped /usr/share. Also the prereqs/packages/archive/Private.SourceBuilt.Artifacts.Bootstrap.tar.gz is symlinked.

The outcome is that the build of dotnet-source-8 is done offline (excluding the actual git clone of the dotnet/dotnet repository).

Pre-review Checklist

For new package PRs only

This PR is marked as fixing a pre-existing package request bug
- Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
REQUIRED - The package is available under an OSI-approved or FSF-approved license
REQUIRED - The version of the package is still receiving security updates
This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

The upstream project actually supports multiple concurrent versions.
Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

The security fix is recorded in the advisories repo

For version bump PRs

The epoch field is reset to 0

For PRs that add patches

Patch source is documented

ader1990 · 2024-11-07T15:44:22Z

dotnet-source-8.yaml

@@ -0,0 +1,210 @@
+package:
+  name: dotnet-source-8


An option would be to leave the current file dotnet-8.yaml to use the bootstrap package, as it is almost identical (just the prep.sh was removed).

xnox · 2024-11-07T16:07:13Z

dotnet-bootstrap-8.yaml

+    strip-prefix: v
+    use-tag: true
+    tag-filter: "v8"
+


we could also keep update: enabled: false & have update-excuse: saying this is a bootstrap package.
as we typically do not want to upgrade bootstrap packages by default.

xnox · 2024-11-07T16:07:45Z

dotnet-bootstrap-8.yaml

+  pipeline:
+    - name: Basic .NET command test
+      runs: |
+        echo 1 # TBD


it's also sort of ok to not have tests for bootstrap; as it's sole purpose is ability to build the real package.

dotnet-source-8.yaml

ader1990 · 2024-11-08T15:01:49Z

dotnet-source-8.yaml

+            /p:MinimalConsoleLogOutput=false \
+            /p:SkipPortableRuntimeBuild=true \
+            /p:BuildWithOnlineSources=false \
+            /p:Configuration=Debug


to be reverted, added it here to have a way of build if anyone wants.

Size differences:

release version of dotnet

du -sh /usr/share/dotnet-source/
481.2M /usr/share/dotnet-source/

debug version of dotnet

du -sh /usr/share/dotnet-source/
559.3M /usr/share/dotnet-source/

do not want, too big.

xnox · 2024-11-18T14:15:59Z

dotnet-bootstrap-8.yaml

@@ -0,0 +1,71 @@
+package:
+  name: dotnet-bootstrap-8
+  version: 8.0.10


Please bump to .11 =) now that it is out.

xnox · 2024-11-18T14:16:25Z

dotnet-source-8.yaml

+package:
+  name: dotnet-source-8
+  version: 8.0.10
+  epoch: 1


also bump to 8.0.11

dotnet-bootstrap-8: add subpackage for the dotnet build requirements

ed130ae

ader1990 commented Nov 7, 2024

View reviewed changes

ader1990 changed the title ~~Build dotnet-8 using a bootstrap package~~ [WOIP] Build dotnet-8 using a bootstrap package Nov 7, 2024

ader1990 force-pushed the dotnet-8-bootstrap-sdk branch from 1e3b12f to fe756ae Compare November 7, 2024 15:50

ader1990 added 3 commits November 7, 2024 15:51

dotnet-source-8: add package relying on dotnet-bootstrap

2cb4b9c

dotnet-bootstrap: fix libcoreclrtraceptprovider.so liblttng-ust.so.0

3901c9f

dotnet-source-8: fix the .dotnet symlink

0a0937c

ader1990 force-pushed the dotnet-8-bootstrap-sdk branch from fe756ae to 0a0937c Compare November 7, 2024 15:51

xnox reviewed Nov 7, 2024

View reviewed changes

dotnet-source-8.yaml Outdated Show resolved Hide resolved

dotnet-source-8: rename all packages

10b861d

xnox added the approved-to-run A repo member has approved this external contribution label Nov 8, 2024

dotnet-source-8: use configuration debug

32671bc

ader1990 force-pushed the dotnet-8-bootstrap-sdk branch from 0c992b6 to 32671bc Compare November 8, 2024 15:00

ader1990 commented Nov 8, 2024

View reviewed changes

xnox reviewed Nov 18, 2024

View reviewed changes

dotnet-bootstrap-8.yaml

@@ -0,0 +1,71 @@

package:

name: dotnet-bootstrap-8

version: 8.0.10

Copy link

Member

xnox Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump to .11 =) now that it is out.

xnox reviewed Nov 18, 2024

View reviewed changes

dotnet-source-8.yaml

package:

name: dotnet-source-8

version: 8.0.10

epoch: 1

Copy link

Member

xnox Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bump to 8.0.11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WOIP] Build dotnet-8 using a bootstrap package #33564

[WOIP] Build dotnet-8 using a bootstrap package #33564

ader1990 commented Nov 7, 2024

ader1990 Nov 7, 2024 •

edited

Loading

xnox Nov 7, 2024

xnox Nov 7, 2024

xnox Nov 7, 2024

ader1990 Nov 8, 2024

xnox Nov 18, 2024

xnox Nov 18, 2024

xnox Nov 18, 2024

[WOIP] Build dotnet-8 using a bootstrap package #33564

Are you sure you want to change the base?

[WOIP] Build dotnet-8 using a bootstrap package #33564

Conversation

ader1990 commented Nov 7, 2024

Pre-review Checklist

For new package PRs only

For new version streams

For package updates (renames) in the base images

For security-related PRs

For version bump PRs

For PRs that add patches

ader1990 Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

xnox Nov 7, 2024

Choose a reason for hiding this comment

xnox Nov 7, 2024

Choose a reason for hiding this comment

xnox Nov 7, 2024

Choose a reason for hiding this comment

ader1990 Nov 8, 2024

Choose a reason for hiding this comment

release version of dotnet

debug version of dotnet

xnox Nov 18, 2024

Choose a reason for hiding this comment

xnox Nov 18, 2024

Choose a reason for hiding this comment

xnox Nov 18, 2024

Choose a reason for hiding this comment

ader1990 Nov 7, 2024 •

edited

Loading