Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice-24.8/24.8.3.2 package update #33666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 8, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Nov 8, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 8, 2024

Gen AI suggestions to solve the build error:

Based on the build error, here are some suggestions to fix the issue:

  1. The primary error appears to be a C++ compilation error in cppu/source/typelib/static_types.cxx:
error: '(((const rtl::OUString*)(& s_aTypeNames)) != 0)' is not a constant expression

This suggests a compatibility issue with the C++ compiler version. Here are steps to try:

  1. Add gcc-13 explicitly to the build dependencies if not already present:
environment:
  contents:
    packages:
      - gcc-13
      - g++-13
  1. Try setting compiler flags to enforce C++17 or C++20 mode by adding to the environment:
environment:
  environment:
    CXXFLAGS: "-std=c++17"
  1. Consider adding the following build dependencies that might help with C++ compilation:
environment:
  contents:
    packages:
      - libstdc++-dev
      - cpp
  1. The error involves string literals, so you might need to add:
  environment:
    CPPFLAGS: "-DU_USING_ICU_NAMESPACE=1"

If these don't resolve the issue, you can debug interactively by:

  1. Run melange build with --interactive
  2. When the shell opens, navigate to the failing directory
  3. Try manually compiling the failing file:
g++ -c static_types.cxx -I../../include

The error suggests there might be an issue with how string literals are being handled in the codebase, possibly related to Unicode string handling or compiler compatibility.

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@mamccorm mamccorm force-pushed the wolfictl-2da6807a-40cc-448d-92e9-a76e44afd37f branch from a552b7f to 914c0db Compare November 11, 2024 19:11
Copy link
Contributor Author

octo-sts bot commented Nov 11, 2024

Gen AI suggestions to solve the build error:

Based on the build error, here are some suggestions to debug and fix the issue:

  1. The main error is a compilation error in cppu/source/typelib/static_types.cxx:
error: '(((const rtl::OUString*)(& s_aTypeNames)) != 0)' is not a constant expression

This appears to be a C++ compiler issue related to string literals and constant expressions. Here are steps to try:

  1. Add gcc-12 to the build dependencies as this version might handle the constant expressions better:
environment:
  contents:
    packages:
      - gcc-12
      - g++-12
  1. If that doesn't work, try adding compiler flags to force C++17 or C++20 mode which have better handling of constant expressions:
pipeline:
  - runs: |
      export CXXFLAGS="-std=c++17"  # or -std=c++20
      ./autogen.sh
  1. Check if there are any patches available upstream for this specific issue. Look at:
  • The LibreOffice bug tracker
  • Recent commits in the 24.8 branch
  • Patches from other distributions building LibreOffice
  1. You can debug interactively using:
melange build --interactive libreoffice-24.8.yaml

Then inside the shell:

cd /home/build
CXXFLAGS="-std=c++17" make -j$(nproc)
  1. Consider adding these compiler-related packages to ensure full build toolchain:
environment:
  contents:
    packages:
      - libstdc++-dev
      - cpp

The focus should be on the C++ compiler configuration since this is a constant expression evaluation issue during compilation.

@dannf dannf self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants