Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolv_wrapper dep #33810

Merged
merged 3 commits into from
Nov 12, 2024
Merged

add resolv_wrapper dep #33810

merged 3 commits into from
Nov 12, 2024

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented Nov 11, 2024

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax marked this pull request as ready for review November 11, 2024 16:50
resolv_wrapper.yaml Outdated Show resolved Hide resolved
Co-authored-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: Furkan Türkal <furkan.turkal@hotmail.com>
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at fs of the package, we have man page in main package as well, we can consider add a split/manpages to handle that.

Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax
Copy link
Member Author

Dentrax commented Nov 12, 2024

looking at fs of the package, we have man page in main package as well, we can consider add a split/manpages to handle that.

Nice catch, done.

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! this is ready to 🚢 now.

@kranurag7 kranurag7 merged commit 20ebaac into wolfi-dev:main Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants