Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py3-requests-unixsocket package #33946

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

kranurag7
Copy link
Member

dependency for ansible-runner-http package.

using py/pip-build-install pipeline was not possible given the project is still using setup.py and haven't made the transition to using pyproject.toml as of now.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
the latest tag is missing on git and we need that for building
application.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@kranurag7 kranurag7 marked this pull request as ready for review November 12, 2024 20:10
@kranurag7
Copy link
Member Author

Notes:
we are not using multi-version python here. I really want to use that but py/pip-build-install pipeline breaks. Upstream project doesn't use pyproject.toml as of now.

The disadvantage of not doing multi-version will mean that all the package that'll pull this as runtime dependency will not have multi-version python either. :(

This is what I found out during my building/testing cycle; reviews/suggestion appreciated if there's a workaround for this.

I can try using range and doing exactly similar package naming to what our py/pip-build-install pipeline does but not sure if that's a good way to go about it.

Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
@pnasrat
Copy link
Member

pnasrat commented Nov 13, 2024

@kranurag7 please see the updated version that is using py3-versioned fine with this project. I'm not sure what your issue was but it was not the pipeline or lack of pyproject.toml. If you have specific errors you encountered we can discuss

Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
@kranurag7 kranurag7 merged commit 34f502b into wolfi-dev:main Nov 14, 2024
14 checks passed
@kranurag7 kranurag7 deleted the kr/py3-requests-unixsocket branch November 14, 2024 19:42
dannf pushed a commit to dannf/os that referenced this pull request Nov 15, 2024
dependency for ansible-runner-http package. 

using `py/pip-build-install` pipeline was not possible given the project
is still using setup.py and haven't made the transition to using
pyproject.toml as of now.

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Co-authored-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants