Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid NPE by skipping nonexistent notifiers in user preferences #6811

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: avoid NPE by skipping nonexistent notifiers in user preferences #6811

merged 1 commit into from
Oct 10, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 10, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复当用户通知偏好设置中出现不存在的通知器名称时会导致 NPE 的问题

此问题可能发生在，通知器由插件或者专业版提供并且修改了偏好设置后禁用了插件或切换到开源版导致找不到该通知器的记录

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang October 10, 2024 05:14
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG October 10, 2024 05:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (d7aba83) to head (b9aaede).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../endpoint/UserNotificationPreferencesEndpoint.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6811      +/-   ##
============================================
- Coverage     57.03%   57.03%   -0.01%     
  Complexity     3978     3978              
============================================
  Files           713      713              
  Lines         23992    23994       +2     
  Branches       1570     1571       +1     
============================================
  Hits          13685    13685              
- Misses         9696     9698       +2     
  Partials        611      611

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JohnNiang
JohnNiang approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good catch!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 9e3f77b into halo-dev:main Oct 10, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.20.0 LTS
Development

Successfully merging this pull request may close these issues.
3 participants
@guqing @JohnNiang @ruibaby