Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid NPE by skipping nonexistent notifiers in user preferences #6811

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: avoid NPE by skipping nonexistent notifiers in user preferences #6811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...src/main/java/run/halo/app/notification/endpoint/UserNotificationPreferencesEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ Mono<ReasonTypeNotifierMatrix> listReasonTypeNotifierMatrix(String username) {
var notifierNames =
reasonTypeNotifierMap.getNotifiers(reasonType.name());
for (String notifierName : notifierNames) {
// Skip if the notifier enabled in the user preference does not
// exist to avoid null index
if (!notifierIndexMap.containsKey(notifierName)) {
continue;
}
var notifierIndex = notifierIndexMap.get(notifierName);
stateMatrix[reasonTypeIndex][notifierIndex] = true;
}
Expand Down
Loading