Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default number of threads to 16 #54

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

robbavey
Copy link
Contributor

@robbavey robbavey commented Mar 6, 2020

Increase the default number of threads passed to the EventProcessorHost
to 16, to match the standard default.

@robbavey robbavey requested a review from karenzone March 6, 2020 17:48
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content, but we need to work through some formatting issues related to notes in bulleted lists.

* **Set number of threads correctly.**

NOTE: The number of threads *must* be greater than or equal to the number of Event hubs plus one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good information. Thank you!
Unfortunately, we've bumped into some of the formatting limitations (notes in bulleted lists) that we talked about earlier.
Screen Shot 2020-03-06 at 1 33 40 PM

To get around these limitations, the content needs to be reworked and restructured. Shall I take a crack at it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone Yes please!

Copy link
Contributor

@karenzone karenzone Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. I've come up with something that I think will work. Check this out:

Screen Shot 2020-03-06 at 2 46 00 PM

If you like this treatment, we can figure out the best way to incorporate it into your work. For example, if commit it could you cherrypick it into your PR?

@colinsurprenant
Copy link

@robbavey Could you clarify what/where the 16 «standard default» is exactly?

@robbavey
Copy link
Contributor Author

robbavey commented Mar 9, 2020

@colinsurprenant When creating an EventProcessorHost, if the executorService is not passed in to the constructor, one is created in the constructor, using the default value of 16.

Also this comment on an issue requesting information on best practices on the size of the executor service for an EventProcessorHost.

Copy link

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Increase the default number of threads passed to the EventProcessorHost
to 16, to match the standard default.
@robbavey robbavey merged commit 37d8f72 into logstash-plugins:master Mar 12, 2020
kares added a commit to kares/logstash-input-azure_event_hubs that referenced this pull request Mar 16, 2020
* master:
  Bump version to 1.2.1 (logstash-plugins#56)
  [DOC] Restructure and expand best practices doc (logstash-plugins#55)
  Increase the default number of threads to 16 (logstash-plugins#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants