-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the default number of threads to 16 #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content, but we need to work through some formatting issues related to notes in bulleted lists.
docs/index.asciidoc
Outdated
* **Set number of threads correctly.** | ||
|
||
NOTE: The number of threads *must* be greater than or equal to the number of Event hubs plus one. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karenzone Yes please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
023f868
to
3bd6c0a
Compare
@robbavey Could you clarify what/where the 16 «standard default» is exactly? |
@colinsurprenant When creating an EventProcessorHost, if the Also this comment on an issue requesting information on best practices on the size of the executor service for an EventProcessorHost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Increase the default number of threads passed to the EventProcessorHost to 16, to match the standard default.
3bd6c0a
to
9bca3e8
Compare
* master: Bump version to 1.2.1 (logstash-plugins#56) [DOC] Restructure and expand best practices doc (logstash-plugins#55) Increase the default number of threads to 16 (logstash-plugins#54)
Increase the default number of threads passed to the EventProcessorHost
to 16, to match the standard default.