Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Restructure and expand best practices doc #55

Merged
merged 3 commits into from
Mar 12, 2020
Merged

[DOC] Restructure and expand best practices doc #55

merged 3 commits into from
Mar 12, 2020

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Mar 6, 2020 •
edited
Loading

Closes #53

robbavey and others added 2 commits March 6, 2020 12:41
@robbavey
Increase the default number of threads to 16
023f868 
Increase the default number of threads passed to the EventProcessorHost
to 16, to match the standard default.

Re-work docs to reflect the fact the change to defaults, and the fact
that event_hubs*partitions is not the maximum number of threads, and
more threads may yield better performance.
@karenzone
Restructure best practices docs
3d9d811
@karenzone
Copy link
Contributor Author

@robbavey I wanted to pick up your doc changes, and so I started with your work.
I would appreciate your help dropping the RB changes. Or, if you take my commit back into your PR, then we'll close this one when you're done.

@karenzone
Copy link
Contributor Author

Looks like this:
Screen Shot 2020-03-06 at 3 22 57 PM

@karenzone karenzone requested a review from robbavey March 6, 2020 21:07
robbavey
robbavey approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit e6ce080 into logstash-plugins:master Mar 12, 2020
@karenzone karenzone deleted the default-thread-doc branch March 12, 2020 19:51
kares added a commit to kares/logstash-input-azure_event_hubs that referenced this pull request Mar 16, 2020
@kares
Merge branch 'master' into scope-imports
06b45d5 
* master:
  Bump version to 1.2.1 (logstash-plugins#56)
  [DOC] Restructure and expand best practices doc (logstash-plugins#55)
  Increase the default number of threads to 16 (logstash-plugins#54)
@karenzone karenzone mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]Clarify guidance on setting number of threads
2 participants
@karenzone @robbavey