Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: scope and review global java_imports #57

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Refactor: scope and review global java_imports #57

merged 3 commits into from
Mar 16, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Mar 12, 2020 •
edited
Loading

@kares kares marked this pull request as ready for review March 13, 2020 14:58
@kares kares marked this pull request as ready for review March 13, 2020 15:08
colinsurprenant
colinsurprenant approved these changes Mar 13, 2020
View reviewed changes
Copy link

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares
Merge branch 'master' into scope-imports
06b45d5 
* master:
  Bump version to 1.2.1 (logstash-plugins#56)
  [DOC] Restructure and expand best practices doc (logstash-plugins#55)
  Increase the default number of threads to 16 (logstash-plugins#54)
@kares
Bump version and fill-in changelog
6acd587
@kares kares merged commit 6b741f1 into logstash-plugins:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinsurprenant colinsurprenant colinsurprenant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kares @colinsurprenant @elasticsearch-bot